[Bazel] Add more llvm tools #163228
Merged
[Bazel] Add more llvm tools #163228
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HighW4y2H3ll
requested review from
aaronmondal,
keith and
rupprecht
as code owners
rupprecht
approved these changes
Oct 20, 2025
|
|
||
| cc_binary( | ||
| name = "llvm-sim", | ||
| testonly = True, |
There was a problem hiding this comment.
Are these tools really just for tests? They seem more like general purpose utils, which happen to be useful for tests.
OTOH, there's not too much harm in marking this testonly. I'd be fine adding them like this and then removing the testonly attr later if we need to use it outside of a testing context.
There was a problem hiding this comment.
Thanks! llvm-sim is added because it's configured in the lit.cfg.py:
llvm-project/llvm/test/lit.cfg.py
Line 268 in 894eaf4
|
|
||
| cc_binary( | ||
| name = "llvm-ctxprof-util", | ||
| testonly = True, |
There was a problem hiding this comment.
The commit description in a737b87 explicitly describes this as a test tool, so this one is definitely OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding llvm-ir2vec, llvm-ctxprof-util (and llvm-sim) in the Bazel configs. llvm-ctxprof-util and llvm-ir2vec are used in several LIT unit tests, and the missing binary is causing unit test failures.
llvm-ctxprof-util:
llvm-project/llvm/test/Analysis/CtxProfAnalysis/flatten-icp.ll
Line 2 in 15cde99
llvm-ir2vec:
llvm-project/llvm/utils/mlgo-utils/IR2Vec/generateTriplets.py
Line 60 in 55d4e92